From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 0/2 v2] perf-kvm support for SVM Date: Mon, 17 Jan 2011 12:34:21 +0100 Message-ID: <20110117113421.GC31122@amd.com> References: <1295019902-31339-1-git-send-email-joerg.roedel@amd.com> <4D32CD45.3090503@redhat.com> <20110116153506.GI6376@8bytes.org> <4D3310E3.9020909@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Joerg Roedel , Marcelo Tosatti , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4D3310E3.9020909@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Sun, Jan 16, 2011 at 10:38:11AM -0500, Avi Kivity wrote: > On 01/16/2011 05:35 PM, Joerg Roedel wrote: > > On Sun, Jan 16, 2011 at 12:49:41PM +0200, Avi Kivity wrote: > > > On 01/14/2011 05:45 PM, Joerg Roedel wrote: > > > > >> here is the reworked version of the patch-set. Only patch 1/2 has > > >> changed and now contains the real fix for the crashes that were seen and > > >> has an updated log message. > > >> > > > > > > Thanks, applied. 2.6.37 and earlier aren't affected, yes? So I'm > > > queuing it for 2.6.38 only. > > > > I think the problem is there since KVM has lazy state switching. So the > > fix in patch 1 should make it in all currently maintained stable-trees. > > > > The problem is with load_gs_index(), yes? In 2.6.37 this is called > before stgi(), so it's protected from nmi. Ok, you are right :) So the fix is only necessary for 2.6.38. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632