From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, quintela@redhat.com, mst@redhat.com
Subject: Re: [PATCH v2] device-assignment: Properly terminate vmsd.fields
Date: Thu, 20 Jan 2011 14:08:14 -0200 [thread overview]
Message-ID: <20110120160814.GC5996@amt.cnet> (raw)
In-Reply-To: <20110117171218.29227.19416.stgit@s20.home>
On Mon, Jan 17, 2011 at 10:17:49AM -0700, Alex Williamson wrote:
> The vmsd code expects the fields structure to be properly terminated,
> not NULL. An assigned device should never be saved or restored, and
> recent qemu fixes to the no_migrate flag should ensure this, but let's
> avoid setting the wrong precedent.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> v2:
> - Change to commit log only, was "device-assignment: Add fields to
> VMStateDescription". Recent qemu.git no_migrate changes avoid
> potential segfault, but this should still be applied for correctness.
>
> hw/device-assignment.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2011-01-20 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 17:17 [PATCH v2] device-assignment: Properly terminate vmsd.fields Alex Williamson
2011-01-19 15:40 ` Juan Quintela
2011-01-20 16:08 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120160814.GC5996@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox