From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] device-assignment: Properly terminate vmsd.fields Date: Thu, 20 Jan 2011 14:08:14 -0200 Message-ID: <20110120160814.GC5996@amt.cnet> References: <20110117171218.29227.19416.stgit@s20.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, quintela@redhat.com, mst@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842Ab1ATWYV (ORCPT ); Thu, 20 Jan 2011 17:24:21 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0KMOL0G004329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Jan 2011 17:24:21 -0500 Content-Disposition: inline In-Reply-To: <20110117171218.29227.19416.stgit@s20.home> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 17, 2011 at 10:17:49AM -0700, Alex Williamson wrote: > The vmsd code expects the fields structure to be properly terminated, > not NULL. An assigned device should never be saved or restored, and > recent qemu fixes to the no_migrate flag should ensure this, but let's > avoid setting the wrong precedent. > > Signed-off-by: Alex Williamson > --- > > v2: > - Change to commit log only, was "device-assignment: Add fields to > VMStateDescription". Recent qemu.git no_migrate changes avoid > potential segfault, but this should still be applied for correctness. > > hw/device-assignment.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) Applied, thanks.