From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to
 net/block/fd device
Date: Wed, 2 Feb 2011 17:12:14 +0200
Message-ID: <20110202151214.GN14984@redhat.com>
References: <1291808109-22563-1-git-send-email-gleb@redhat.com>
 <1291808109-22563-13-git-send-email-gleb@redhat.com>
 <m3k4hi8ofc.fsf@blackfin.pond.sub.org>
 <20110202151004.GM14984@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, blauwirbel@gmail.com, kevin@koconnor.net,
	kvm@vger.kernel.org
To: Markus Armbruster <armbru@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34150 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753660Ab1BBPMT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Feb 2011 10:12:19 -0500
Content-Disposition: inline
In-Reply-To: <20110202151004.GM14984@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Feb 02, 2011 at 05:10:04PM +0200, Gleb Natapov wrote:
> On Wed, Feb 02, 2011 at 04:08:07PM +0100, Markus Armbruster wrote:
> > Gleb Natapov <gleb@redhat.com> writes:
> > 
> > > If bootindex is specified on command line a string that describes device
> > > in firmware readable way is added into sorted list. Later this list will
> > > be passed into firmware to control boot order.
> > >
> > > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > 
> > Just noticed something that slipped through review:
> > 
> > [...]
> > > diff --git a/vl.c b/vl.c
> > > index 2cd263e..dadc161 100644
> > > --- a/vl.c
> > > +++ b/vl.c
> > [...]
> > > @@ -693,6 +704,35 @@ static void restore_boot_devices(void *opaque)
> > >      qemu_free(standard_boot_devices);
> > >  }
> > >  
> > > +void add_boot_device_path(int32_t bootindex, DeviceState *dev,
> > > +                          const char *suffix)
> > > +{
> > > +    FWBootEntry *node, *i;
> > > +
> > > +    if (bootindex < 0) {
> > > +        return;
> > > +    }
> > > +
> > > +    assert(dev != NULL || suffix != NULL);
> > > +
> > > +    node = qemu_mallocz(sizeof(FWBootEntry));
> > > +    node->bootindex = bootindex;
> > > +    node->suffix = strdup(suffix);
> > 
> > qemu_strdup()?
> > 
> Yap. Will fix.
> 
BTW we have 40 uses of strdup and 75 uses of qemu_strdup.

> > > +    node->dev = dev;
> > > +
> > > +    QTAILQ_FOREACH(i, &fw_boot_order, link) {
> > > +        if (i->bootindex == bootindex) {
> > > +            fprintf(stderr, "Two devices with same boot index %d\n", bootindex);
> > > +            exit(1);
> > > +        } else if (i->bootindex < bootindex) {
> > > +            continue;
> > > +        }
> > > +        QTAILQ_INSERT_BEFORE(i, node, link);
> > > +        return;
> > > +    }
> > > +    QTAILQ_INSERT_TAIL(&fw_boot_order, node, link);
> > > +}
> > > +
> > >  static void numa_add(const char *optarg)
> > >  {
> > >      char option[128];
> 
> --
> 			Gleb.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.