From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v3 02/23] Stop current VCPU on synchronous reset requests Date: Fri, 4 Feb 2011 19:22:41 -0200 Message-ID: <20110204212241.GA12823@amt.cnet> References: <4D4C389D.4060607@codemonkey.ws> <4D4C3CC8.9040202@siemens.com> <4D4C43A5.2030207@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60330 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267Ab1BDVXK (ORCPT ); Fri, 4 Feb 2011 16:23:10 -0500 Content-Disposition: inline In-Reply-To: <4D4C43A5.2030207@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Feb 04, 2011 at 07:21:25PM +0100, Jan Kiszka wrote: > On 2011-02-04 18:52, Jan Kiszka wrote: > > On 2011-02-04 18:34, Anthony Liguori wrote: > >> On 02/04/2011 09:47 AM, Marcelo Tosatti wrote: > >>> The following changes since commit bfddb47a343b4718e5768aa80bce8adead0f7fca: > >>> > >>> Open up the 0.15 development branch (2011-02-02 08:39:28 +0100) > >>> > >> > >> This series breaks reboot of a Linux guest both with TCG and KVM. > >> > >> Perhaps it's a conflict with the ioapic changes from Jan? I can post a > >> tree but if you just rebase to the latest master there shouldn't be any > >> conflicts. > >> > > > > The problem is some patch in the queue itself. I obviously missed that > > case. Will have a look. > > > > Yet another IOTHREAD vs. !IOTHREAD case: We don't need to do anything in > cpu_stop_current in the single-thread setup as qemu_notify_event already > kicks us out. Specifically, we must not set the current cpu on > stop as reset happens without stop/start. > > This replaces patch 2 in the series. > > Jan Ugh, will check about autotesting !CONFIG_IOTHREAD. Anthony, queue updated. git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master