From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu execution Date: Wed, 9 Feb 2011 12:44:29 -0200 Message-ID: <20110209144429.GC32689@amt.cnet> References: <149ef70e3a2ebe96529b0956da4bd4009099e3ac.1297077507.git.jan.kiszka@siemens.com> <20110208233903.GA16795@amt.cnet> <4D52495B.8010004@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18865 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755508Ab1BIOoz (ORCPT ); Wed, 9 Feb 2011 09:44:55 -0500 Content-Disposition: inline In-Reply-To: <4D52495B.8010004@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Feb 09, 2011 at 08:59:23AM +0100, Jan Kiszka wrote: > On 2011-02-09 00:39, Marcelo Tosatti wrote: > > On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote: > >> Mixing up TCG bits with KVM already led to problems around eflags > >> emulation on x86. Moreover, quite some code that TCG requires on cpu > >> enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and > >> kvm_cpu_exec as early as possible. > >> > >> The core logic of cpu_halted from cpu_exec is added to > >> kvm_arch_process_irqchip_events. Moving away from cpu_exec makes > >> exception_index meaningless for KVM, we can simply pass the exit reason > >> directly (only "EXCP_DEBUG vs. rest" is relevant). > >> > >> Signed-off-by: Jan Kiszka > >> --- > >> cpu-exec.c | 19 ++++++------------- > >> cpus.c | 10 +++++----- > >> kvm-all.c | 19 +++++++++---------- > >> target-i386/kvm.c | 6 +++--- > >> 4 files changed, 23 insertions(+), 31 deletions(-) > >> > >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c > >> index ba183c4..377a0a3 100644 > >> --- a/target-i386/kvm.c > >> +++ b/target-i386/kvm.c > >> @@ -1502,12 +1502,13 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run) > >> > >> int kvm_arch_process_irqchip_events(CPUState *env) > >> { > >> + if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) { > >> + env->halted = 0; > >> + } > > > > Why is it necessary to clear env->halted here? > > Because we no longer come along cpu_halted() in cpu_exec(). This > corresponds to the tail of process_irqchip_events() in qemu-kvm This is not yet well integrated, we probably don't need env->halted anymore (see cpu_has_work). Can be improved later though.