From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [RESEND][PATCH] qemu-kvm: Drop vga dirty logging workarounds Date: Wed, 16 Feb 2011 14:58:54 -0200 Message-ID: <20110216165854.GA16068@amt.cnet> References: <4D597228.2030404@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42560 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437Ab1BPRT7 (ORCPT ); Wed, 16 Feb 2011 12:19:59 -0500 Content-Disposition: inline In-Reply-To: <4D597228.2030404@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Feb 14, 2011 at 07:19:20PM +0100, Jan Kiszka wrote: > These diffs to upstream should all date back to the days qemu-kvm > supported vga dirty logging with restricted/broken kvm kernel modules. > We no longer do, so there is no need for those workarounds. Even worse > they can trigger internal bug checks these days: > > BUG: kvm_dirty_pages_log_change: invalid parameters 00000000000a8000-00000000000affff > > Signed-off-by: Jan Kiszka > --- > > When the log_start/stop callbacks are upstream and about to be merged > back, you likely want this patch to be applied first. :) Applied, thanks.