From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection
 code
Date: Thu, 17 Feb 2011 16:08:58 -0200
Message-ID: <20110217180858.GB12113@amt.cnet>
References: <cover.1297758211.git.jan.kiszka@siemens.com>
 <67f48a7cb1aebebb1dc4af0f413379686dcff24b.1297758211.git.jan.kiszka@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, Huang Ying <ying.huang@intel.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47994 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756797Ab1BQSJu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 17 Feb 2011 13:09:50 -0500
Content-Disposition: inline
In-Reply-To: <67f48a7cb1aebebb1dc4af0f413379686dcff24b.1297758211.git.jan.kiszka@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Feb 15, 2011 at 09:23:33AM +0100, Jan Kiszka wrote:
> This switches KVM's MCE injection path to cpu_x86_inject_mce, both for
> SIGBUS and monitor initiated events. This means we prepare the MCA MSRs
> in the VCPUState also for KVM.
> 
> We have to drop the MSRs writeback restrictions for this purpose which
> is now safe as every uncoordinated MSR injection is removed with this
> patch.
> 
> We have to execute every per-VCPU event setup on the target VCPU as we
> are performing a read-modify-write on its state.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> CC: Huang Ying <ying.huang@intel.com>
> CC: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> CC: Jin Dongming <jin.dongming@np.css.fujitsu.com>

Difficult to review, please split:

- drop writeback restriction
- unify monitor/sigbus injection paths 
- cleanup / refactor