From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: kvm_amd BUG: unable to handle kernel NULL pointer dereference at 00000014 Date: Mon, 7 Mar 2011 14:29:52 +0100 Message-ID: <20110307132952.GG17719@amd.com> References: <4D736090.1000300@redhat.com> <20110307121138.GD17719@amd.com> <4D74D486.2080206@redhat.com> <20110307131649.GF17719@amd.com> <4D74DBAA.7020901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: IVAN ANGELOV , "kvm@vger.kernel.org" , Ingo Molnar , "x86@kernel.org" To: Avi Kivity Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:51144 "EHLO TX2EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754Ab1CGNaK (ORCPT ); Mon, 7 Mar 2011 08:30:10 -0500 Content-Disposition: inline In-Reply-To: <4D74DBAA.7020901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Mar 07, 2011 at 08:20:42AM -0500, Avi Kivity wrote: > On 03/07/2011 03:16 PM, Roedel, Joerg wrote: > > According to the comments in stackprotector.h its the same on amd64 (the > > difference is that gcc expects the canary value at a different offset > > from %gs). > > So we should probably unlazy %gs reload alltogether. > > On x86_64 we don't do lazy %gs reload (lazy %fs instead), so it should > work as is. Right. I mixed that up with the lazy KERNEL_GS_BASE switching on amd64. -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632