From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [stable] [PATCH] kvm: fix crash on irqfd deassign Date: Thu, 17 Mar 2011 09:13:08 -0700 Message-ID: <20110317161308.GA12740@kroah.com> References: <20110317085333.GA7336@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jean-philippe.menil@univ-nantes.fr, stable@kernel.org, Jason Wang To: "Michael S. Tsirkin" Return-path: Received: from kroah.org ([198.145.64.141]:37690 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754439Ab1CQQNs (ORCPT ); Thu, 17 Mar 2011 12:13:48 -0400 Content-Disposition: inline In-Reply-To: <20110317085333.GA7336@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Mar 17, 2011 at 10:53:33AM +0200, Michael S. Tsirkin wrote: > irqfd in kvm used flush_work incorrectly: > it assumed that work scheduled previously can't run > after flush_work, but since kvm uses a non-reentrant > workqueue (by means of schedule_work) > we need flush_work_sync to get that guarantee. > > Signed-off-by: Michael S. Tsirkin > Reported-by: Jean-Philippe Menil > Tested-by: Jean-Philippe Menil > --- > > Note: this is needed for kernel 2.6.39 and earlier. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. thanks, greg k-h