From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] kvm: fix crash on irqfd deassign
Date: Fri, 18 Mar 2011 15:21:02 +0200
Message-ID: <20110318132102.GD4221@redhat.com>
References: <20110317085333.GA7336@redhat.com>
	<20110317161308.GA12740@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>, linux-kernel@vger.kernel.org,
        jean-philippe.menil@univ-nantes.fr, Avi Kivity <avi@redhat.com>,
        stable@kernel.org
To: Greg KH <greg@kroah.com>
Return-path: <stable-bounces@linux.kernel.org>
Content-Disposition: inline
In-Reply-To: <20110317161308.GA12740@kroah.com>
List-Unsubscribe: <http://linux.kernel.org/mailman/options/stable>,
	<mailto:stable-request@linux.kernel.org?subject=unsubscribe>
List-Archive: <http://linux.kernel.org/mailman/private/stable/>
List-Post: <mailto:stable@linux.kernel.org>
List-Help: <mailto:stable-request@linux.kernel.org?subject=help>
List-Subscribe: <http://linux.kernel.org/mailman/listinfo/stable>,
	<mailto:stable-request@linux.kernel.org?subject=subscribe>
Sender: stable-bounces@linux.kernel.org
Errors-To: stable-bounces@linux.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, Mar 17, 2011 at 09:13:08AM -0700, Greg KH wrote:
> On Thu, Mar 17, 2011 at 10:53:33AM +0200, Michael S. Tsirkin wrote:
> > irqfd in kvm used flush_work incorrectly:
> > it assumed that work scheduled previously can't run
> > after flush_work, but since kvm uses a non-reentrant
> > workqueue (by means of schedule_work)
> > we need flush_work_sync to get that guarantee.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > Tested-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > ---
> > 
> > Note: this is needed for kernel 2.6.39 and earlier.
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> thanks,
> 
> greg k-h

What I missed is Cc: stable@kernel.org in the text?
OK, thanks for the correction.  Actually I forgot, Avi and Marcelo want
to handle stable patches for kvm themselves.
Avi, Marcelo, right?
So Greg, you can forget about this one for now.

Thanks,

-- 
MST