Re: [PATCH 1/5] KVM: x86 emulator: Use single stage decoding for Group 1 instructions

[Takuya Yoshikawa <takuya.yoshikawa@gmail.com>]

On Tue, 22 Mar 2011 14:53:21 +0200
Avi Kivity <avi@redhat.com> wrote:

> 
> I prefer to have the patchset fully updated, even if it takes a while.  
> Good luck with the recovery!

Things already got back as usual, thanks.
I had expected much longer time.

BTW, is it better to wait until rc1 is released when we send
patches for the next merge window?

> > >  >  What is the difference of CMPS and SCAS?
> > >  >
> > >  >
> > >  One compares to memory locations and another memory with AX register.
> >
> > I wanted to know whether we should introduce em_cmps() or em_scas() later.
> >
> > Probably we can eliminate introducing em_scas() because it should be
> > completely same as em_cmp().
> 
> I agree.
> 
> > But em_cmps() will be needed for inserting
> >    c->dst.type = OP_NONE;
> > before em_cmp().
> 
> I think we can put this line into em_cmp().  In fact, it looks like CMP 
> r/m, reg will now write back the data into memory, which is wrong.  So I 
> recommend a first patch to add c->dst.type = OP_NONE before the cmp: 
> label, so we have a fix patch followed by a refactoring patch.

I'll update like that!

> 
> Later we can have a ReadOnly opcode table bit, so we can disable 
> writeback from the opcode tables, not the code.

OK, then we can remove the line at this timing.

Takuya