From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com
Subject: Re: [PATCH 4/5] KVM: x86 emulator: Use single stage decoding for PUSHA and POPA instructions
Date: Wed, 23 Mar 2011 00:54:58 +0900 [thread overview]
Message-ID: <20110323005458.c7eaa5c4.takuya.yoshikawa@gmail.com> (raw)
In-Reply-To: <4D889F08.4070901@redhat.com>
On Tue, 22 Mar 2011 15:07:20 +0200
Avi Kivity <avi@redhat.com> wrote:
> > +static int em_pusha(struct x86_emulate_ctxt *ctxt)
> > +{
> > + return emulate_pusha(ctxt, ctxt->ops);
> > +}
> > +
>
> You can simply rename/update emulate_pusha/emulate_popa, since they have
> no other callers.
>
I intentionally left emulate_* in this version because I thought
there might be some reason for introducing new em_* naming.
OK, I'll remove useless old functions.
Takuya
next prev parent reply other threads:[~2011-03-22 15:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 15:15 [PATCH 0/5] KVM: x86 emulator: Use single stage decoding -- Part 1 Takuya Yoshikawa
2011-03-13 15:17 ` [PATCH 1/5] KVM: x86 emulator: Use single stage decoding for Group 1 instructions Takuya Yoshikawa
2011-03-14 15:11 ` Gleb Natapov
2011-03-14 21:32 ` Takuya Yoshikawa
2011-03-15 9:35 ` Gleb Natapov
2011-03-15 14:06 ` Takuya Yoshikawa
2011-03-22 12:53 ` Avi Kivity
2011-03-22 15:35 ` Takuya Yoshikawa
2011-03-22 15:53 ` Avi Kivity
2011-03-22 12:55 ` Avi Kivity
2011-03-22 15:37 ` Takuya Yoshikawa
2011-03-13 15:19 ` [PATCH 2/5] KVM: x86 emulator: Use single stage decoding for PUSH/POP XS instructions Takuya Yoshikawa
2011-03-22 13:03 ` Avi Kivity
2011-03-22 15:45 ` Takuya Yoshikawa
2011-03-13 15:20 ` [PATCH 3/5] KVM: x86 emulator: Use single stage decoding for POP instructions Takuya Yoshikawa
2011-03-22 13:06 ` Avi Kivity
2011-03-22 15:49 ` Takuya Yoshikawa
2011-03-13 15:21 ` [PATCH 4/5] KVM: x86 emulator: Use single stage decoding for PUSHA and POPA instructions Takuya Yoshikawa
2011-03-22 13:07 ` Avi Kivity
2011-03-22 15:54 ` Takuya Yoshikawa [this message]
2011-03-22 16:34 ` Avi Kivity
2011-03-13 15:23 ` [PATCH 5/5] KVM: x86 emulator: Use single stage decoding for PUSHF and POPF instructions Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323005458.c7eaa5c4.takuya.yoshikawa@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox