From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Subject: Re: [PATCH 4/5] KVM: x86 emulator: Use single stage decoding for
 PUSHA and POPA instructions
Date: Wed, 23 Mar 2011 00:54:58 +0900
Message-ID: <20110323005458.c7eaa5c4.takuya.yoshikawa@gmail.com>
References: <20110314001524.f35e8a3f.takuya.yoshikawa@gmail.com>
	<20110314002152.fc032e5d.takuya.yoshikawa@gmail.com>
	<4D889F08.4070901@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:56322 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751855Ab1CVPzK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 22 Mar 2011 11:55:10 -0400
Received: by wwa36 with SMTP id 36so8991097wwa.1
        for <kvm@vger.kernel.org>; Tue, 22 Mar 2011 08:55:08 -0700 (PDT)
In-Reply-To: <4D889F08.4070901@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 22 Mar 2011 15:07:20 +0200
Avi Kivity <avi@redhat.com> wrote:

> > +static int em_pusha(struct x86_emulate_ctxt *ctxt)
> > +{
> > +	return emulate_pusha(ctxt, ctxt->ops);
> > +}
> > +
> 
> You can simply rename/update emulate_pusha/emulate_popa, since they have 
> no other callers.
> 

I intentionally left emulate_* in this version because I thought
there might be some reason for introducing new em_* naming.

OK, I'll remove useless old functions.

Takuya