From: Joerg Roedel <joro@8bytes.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 01/13] KVM: x86 emulator: add framework for instruction
Date: Mon, 28 Mar 2011 12:19:34 +0200 [thread overview]
Message-ID: <20110328101933.GE28219@8bytes.org> (raw)
In-Reply-To: <20110327125656.GE7766@redhat.com>
On Sun, Mar 27, 2011 at 02:56:56PM +0200, Gleb Natapov wrote:
> On Fri, Mar 25, 2011 at 10:29:04AM +0100, Joerg Roedel wrote:
> > @@ -259,6 +267,18 @@ struct x86_emulate_ctxt {
> > #define X86EMUL_MODE_PROT32 4 /* 32-bit protected mode. */
> > #define X86EMUL_MODE_PROT64 8 /* 64-bit (long) mode. */
> >
> > +enum x86_intercept_stage {
> > + x86_icpt_pre_except,
> > + x86_icpt_post_except,
> > + x86_icpt_post_memaccess,
> > +};
> > +
> > +enum x86_intercept {
> > + x86_intercept_none,
> > +
> > + nr_x86_intercepts
> > +};
> > +
> Can we name enums in upper case please?
Just did a quick grep and it seems that both, upper and lower case is
used in enums throughout the kernel. It makes certainly sense to have it
in upper case to make a visual distinction between constants and
variables, but for the x86_intercept enum this means clobbering the
opcode-tables in the emulator with upper-case strings making them less
readable imo.
But I change x86_intercept_stage to upper-case in the next version.
Joerg
next prev parent reply other threads:[~2011-03-28 10:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 9:29 [PATCH 0/13] KVM: Make the instruction emulator aware of Nested Virtualization v2 Joerg Roedel
2011-03-25 9:29 ` [PATCH 01/13] KVM: x86 emulator: add framework for instruction Joerg Roedel
2011-03-26 9:54 ` Avi Kivity
2011-03-27 12:56 ` Gleb Natapov
2011-03-28 10:19 ` Joerg Roedel [this message]
2011-03-25 9:29 ` [PATCH 02/13] KVM: x86 emulator: add SVM intercepts Joerg Roedel
2011-03-25 9:29 ` [PATCH 03/13] KVM: X86: Don't write-back cpu-state on X86EMUL_INTERCEPTED Joerg Roedel
2011-03-25 9:29 ` [PATCH 04/13] KVM: X86: Add x86 callback for intercept check Joerg Roedel
2011-03-26 9:23 ` Avi Kivity
2011-03-25 9:29 ` [PATCH 05/13] KVM: SVM: Add intercept check for emulated cr accesses Joerg Roedel
2011-03-26 9:37 ` Avi Kivity
2011-03-26 11:06 ` Joerg Roedel
2011-03-27 9:45 ` Avi Kivity
2011-03-25 9:29 ` [PATCH 06/13] KVM: SVM: Add intercept check for accessing dr registers Joerg Roedel
2011-03-25 9:29 ` [PATCH 07/13] KVM: SVM: Add intercept checks for descriptor table accesses Joerg Roedel
2011-03-26 9:43 ` Avi Kivity
2011-03-26 11:10 ` Joerg Roedel
2011-03-25 9:29 ` [PATCH 08/13] KVM: SVM: Add intercept checks for SVM instructions Joerg Roedel
2011-03-25 9:29 ` [PATCH 09/13] KVM: SVM: Add intercept checks for remaining group7 instructions Joerg Roedel
2011-03-25 9:29 ` [PATCH 10/13] KVM: SVM: Add intercept checks for remaining twobyte instructions Joerg Roedel
2011-03-25 9:29 ` [PATCH 11/13] KVM: SVM: Add intercept checks for one-byte instructions Joerg Roedel
2011-03-26 9:53 ` Avi Kivity
2011-03-25 9:29 ` [PATCH 12/13] KVM: SVM: Add checks for IO instructions Joerg Roedel
2011-03-25 9:29 ` [PATCH 13/13] KVM: SVM: Remove nested sel_cr0_write handling code Joerg Roedel
2011-03-26 9:55 ` [PATCH 0/13] KVM: Make the instruction emulator aware of Nested Virtualization v2 Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328101933.GE28219@8bytes.org \
--to=joro@8bytes.org \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).