From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH 0/3] Unmapped page cache control (v5) Date: Sun, 3 Apr 2011 18:39:12 +0900 (JST) Message-ID: <20110403183927.AE4D.A69D9226@jp.fujitsu.com> References: <20110401222250.A894.A69D9226@jp.fujitsu.com> <20110401180455.GU2879@balbir.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org, akpm@linux-foundation.org, npiggin@kernel.dk, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, cl@linux.com, kamezawa.hiroyu@jp.fujitsu.com, Mel Gorman , Minchan Kim To: balbir@linux.vnet.ibm.com Return-path: In-Reply-To: <20110401180455.GU2879@balbir.in.ibm.com> Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org > > > > Hm. OK, I may misread. > > > > Can you please explain the reason why de-duplication feature need to selectable and > > > > disabled by defaut. "explicity enable" mean this feature want to spot corner case issue?? > > > > > > Yes, because given a selection of choices (including what you > > > mentioned in the review), it would be nice to have > > > this selectable. > > > > It's no good answer. :-/ > > I am afraid I cannot please you with my answers > > > Who need the feature and who shouldn't use it? It this enough valuable for enough large > > people? That's my question point. > > > > You can see the use cases documented, including when running Linux as > a guest under other hypervisors, Which hypervisor? If this patch is unrelated 99.9999% people, shouldn't you have to reduce negative impact? > today we have a choice of not using > host page cache with cache=none, but nothing the other way round. > There are other use cases for embedded folks (in terms of controlling > unmapped page cache), please see previous discussions. Is there other usecase? really? Where exist? Why do you start to talk about embedded sudenly? I reviewed this as virtualization feature beucase you wrote so in [path 0/3]. Why do you change your point suddenly? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org