From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [RFC PATCH 2/2] KVM: x86 emulator: Cleanup emulate_push() writebacks Date: Mon, 4 Apr 2011 01:09:10 +0900 Message-ID: <20110404010910.c4d417ff.takuya.yoshikawa@gmail.com> References: <20110329013229.20e6168f.takuya.yoshikawa@gmail.com> <20110329013407.c7bcadcc.takuya.yoshikawa@gmail.com> <4D988927.4020003@redhat.com> <20110404005907.0edba901.takuya.yoshikawa@gmail.com> <4D989A7F.8000700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com To: Avi Kivity Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:37484 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004Ab1DCQJP (ORCPT ); Sun, 3 Apr 2011 12:09:15 -0400 Received: by iwn34 with SMTP id 34so5034614iwn.19 for ; Sun, 03 Apr 2011 09:09:15 -0700 (PDT) In-Reply-To: <4D989A7F.8000700@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: > > IMHO, we are using dst operand for too many things. > > > > In the case of CMP, I first tried to use src2 to clearly follow the > > SDM's "second source operand" terminology. But it seemed not worth > > it now. > > > > Ah, CMP is encoded as dst/src, so it's best to just disable writeback > there. We could have a bit in the decode tables to auto-disable > writeback, but not sure it is worth it. One more question: Why some functions in this file are defined using "static inline" not just "static" ? I should keep these "inline" ? Takuya -- Takuya Yoshikawa