From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
oswaldo.cadenas@gmail.com
Subject: Re: [PATCH 2/4] Mostly the copied code from perf for argument processing
Date: Fri, 8 Apr 2011 08:04:12 +0200 [thread overview]
Message-ID: <20110408060412.GB902@elte.hu> (raw)
In-Reply-To: <1302241407.32207.49.camel@jaguar>
* Pekka Enberg <penberg@kernel.org> wrote:
> On 04/07/11 13:47, Prasad Joshi wrote:
> > > - parse-options.[ch] has argument processing code.
> > >
> > > - types.h: Additional types for argument processing.
> > >
> > > - strbuf.[ch]: Added a function prefixcmp to compare string prefix
>
> On Thu, 2011-04-07 at 14:17 -0600, David Ahern wrote:
> > Rather than copy perf code, how about a tools/lib?
>
> It's a good idea but lets not do it in our tree. We're still trying to keep
> things well-contained under 'tools/kvm' for merge reasons.
Agreed.
> You could try to do the cleanup in perf tree if you're interested and when
> that hits mainline, we can pull the bits from there and clean up our tree.
Yes, that ordering would make sense - the perf copies of Git code are also much
more complete.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-08 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 19:47 [PATCH 1/4] Generating list of common kvm tool commands Prasad Joshi
2011-04-07 19:47 ` [PATCH 2/4] Mostly the copied code from perf for argument processing Prasad Joshi
2011-04-07 20:17 ` David Ahern
2011-04-08 5:43 ` Pekka Enberg
2011-04-08 6:04 ` Ingo Molnar [this message]
2011-04-07 19:47 ` [PATCH 3/4] Provides the basic Gitish framework Prasad Joshi
2011-04-07 20:14 ` Ingo Molnar
2011-04-07 22:33 ` Prasad Joshi
2011-04-08 5:44 ` Pekka Enberg
2011-04-08 6:10 ` Ingo Molnar
2011-04-07 19:47 ` [PATCH 4/4] Using the Gitish freamwork to run the virtual machine Prasad Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408060412.GB902@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=dsahern@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=oswaldo.cadenas@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox