Re: [PATCH 3/4] Provides the basic Gitish framework

[Ingo Molnar <mingo@elte.hu>]

* Pekka Enberg <penberg@kernel.org> wrote:

> On Thu, 2011-04-07 at 23:33 +0100, Prasad Joshi wrote:
> > On Thu, Apr 7, 2011 at 9:14 PM, Ingo Molnar <mingo@elte.hu> wrote:
> > >
> > > * Prasad Joshi <prasadjoshi124@gmail.com> wrote:
> > >
> > >> - kvm-cmd.h: Adds a new structure cmd_struct to create a table of commands
> > >>   and callback function.
> > >>
> > >> - kvm-cmd.c: implements two main functions for command processing.
> > >>   kvm_get_command(): searches table for specific command.
> > >>   handle_command(): invokes the callback function for a given command.
> > >>
> > >> - kvm-help.[ch] Implements the kvm help command.
> > >
> > > Please credit the people/projects from where you took these bits.
> > 
> > Oh yes!
> > struct cmd_struct and list_common_cmds_help() is copied from perf.
> 
> Please just add that to the changelog.

Yeah - and perf took it from Git :-)

The way we credited the Git project in perf was this commit:

  1b173f77dd0d: perf_counter tools: Add CREDITS file for Git contributors

basically a CREDITS file for Git library contributors. If you expect to take 
more bits, such as the help system (look at tools/perf/Documentation/) and 
other bits, the easiest solution would be for you to take the CREDITS file and 
name it CREDITS-lib or so.

This also serves as a way to grandfather in other history (and copyrights), the 
exact upstream Git sha1 is mentioned. The Git project is GPLv2 as well like the 
kernel and like tools/perf/, so this works out well and you do not have to 
re-credit again and again so precisely, as you take more bits of Git's library 
code.

Thanks,

	Ingo