Re: [PATCH] kvm tools: Introduce KVM VCPU data structure

Ingo Molnar
2011-04-09T12:27:36Z

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 04/09/2011 03:59 PM, Ingo Molnar wrote:
> >
> > * Pekka Enberg <penberg@kernel.org> wrote:
> >
> >> In preparation for threaded execution model, this patch introduces a KVM VCPU
> >> data structure 'struct kvm_cpu'.
> >>
> >> Cc: Asias He <asias.hejun@gmail.com>
> >> Cc: Cyrill Gorcunov <gorcunov@gmail.com>
> >> Cc: Ingo Molnar <mingo@elte.hu>
> >> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> >> ---
> ...
> >
> > This commit causes a segfault for 'kvm run bzImage':
> >
> > (gdb) set args run bzImage
> > (gdb) run
> > Starting program: /home/mingo/tip/tools/kvm/kvm run bzImage
> > [Thread debugging using libthread_db enabled]
> >
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x0000000000405054 in setup_bios (kvm=0x68a010) at bios.c:106
> > 106 memset(p, 0, BDA_END - BDA_START);
>
> Ugh, Pekka, was the memory properly mmaped? Setup bios called multiple
> times in every thread?

Why should mmap() be called in every thread?

Thanks,

Ingo