public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	kvm@vger.kernel.org, Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH] kvm tools: Introduce KVM VCPU data structure
Date: Sat, 9 Apr 2011 14:27:29 +0200	[thread overview]
Message-ID: <20110409122729.GA1547@elte.hu> (raw)
In-Reply-To: <4DA0504D.8050509@gmail.com>


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 04/09/2011 03:59 PM, Ingo Molnar wrote:
> > 
> > * Pekka Enberg <penberg@kernel.org> wrote:
> > 
> >> In preparation for threaded execution model, this patch introduces a KVM VCPU
> >> data structure 'struct kvm_cpu'.
> >>
> >> Cc: Asias He <asias.hejun@gmail.com>
> >> Cc: Cyrill Gorcunov <gorcunov@gmail.com>
> >> Cc: Ingo Molnar <mingo@elte.hu>
> >> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> >> ---
> ...
> > 
> > This commit causes a segfault for 'kvm run bzImage':
> > 
> > (gdb) set args run bzImage
> > (gdb) run
> > Starting program: /home/mingo/tip/tools/kvm/kvm run bzImage
> > [Thread debugging using libthread_db enabled]
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x0000000000405054 in setup_bios (kvm=0x68a010) at bios.c:106
> > 106		memset(p, 0, BDA_END - BDA_START);
> 
> Ugh, Pekka, was the memory properly mmaped? Setup bios called multiple
> times in every thread?

Why should mmap() be called in every thread?

Thanks,

	Ingo

  reply	other threads:[~2011-04-09 12:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-09 10:07 [PATCH] kvm tools: Introduce KVM VCPU data structure Pekka Enberg
2011-04-09 11:59 ` Ingo Molnar
2011-04-09 12:25   ` Cyrill Gorcunov
2011-04-09 12:27     ` Ingo Molnar [this message]
2011-04-09 12:33       ` Cyrill Gorcunov
2011-04-09 12:34         ` Pekka Enberg
2011-04-09 12:35           ` Cyrill Gorcunov
2011-04-09 12:38             ` Pekka Enberg
2011-04-09 12:26   ` Ingo Molnar
2011-04-09 12:30     ` Pekka Enberg
2011-04-09 12:36       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110409122729.GA1547@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox