From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tools: Introduce KVM VCPU data structure
Date: Sat, 9 Apr 2011 14:27:29 +0200
Message-ID: <20110409122729.GA1547@elte.hu>
References: <1302343631-30060-1-git-send-email-penberg@kernel.org>
 <20110409115913.GA26593@elte.hu>
 <4DA0504D.8050509@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>, kvm@vger.kernel.org,
	Asias He <asias.hejun@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:43628 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753928Ab1DIM1g (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 9 Apr 2011 08:27:36 -0400
Content-Disposition: inline
In-Reply-To: <4DA0504D.8050509@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 04/09/2011 03:59 PM, Ingo Molnar wrote:
> > 
> > * Pekka Enberg <penberg@kernel.org> wrote:
> > 
> >> In preparation for threaded execution model, this patch introduces a KVM VCPU
> >> data structure 'struct kvm_cpu'.
> >>
> >> Cc: Asias He <asias.hejun@gmail.com>
> >> Cc: Cyrill Gorcunov <gorcunov@gmail.com>
> >> Cc: Ingo Molnar <mingo@elte.hu>
> >> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> >> ---
> ...
> > 
> > This commit causes a segfault for 'kvm run bzImage':
> > 
> > (gdb) set args run bzImage
> > (gdb) run
> > Starting program: /home/mingo/tip/tools/kvm/kvm run bzImage
> > [Thread debugging using libthread_db enabled]
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x0000000000405054 in setup_bios (kvm=0x68a010) at bios.c:106
> > 106		memset(p, 0, BDA_END - BDA_START);
> 
> Ugh, Pekka, was the memory properly mmaped? Setup bios called multiple
> times in every thread?

Why should mmap() be called in every thread?

Thanks,

	Ingo