From: Ingo Molnar <mingo@elte.hu>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com,
gorcunov@gmail.com, levinsasha928@gmail.com,
stefanha@linux.vnet.ibm.com
Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support
Date: Thu, 14 Apr 2011 10:25:40 +0200 [thread overview]
Message-ID: <20110414082540.GA30848@elte.hu> (raw)
In-Reply-To: <4DA6AC83.7000601@redhat.com>
* Kevin Wolf <kwolf@redhat.com> wrote:
> Am 14.04.2011 10:07, schrieb Ingo Molnar:
> >
> > * Kevin Wolf <kwolf@redhat.com> wrote:
> >
> >> Also at least your qcow1.c is lacking the copyright header. Please add this,
> >> otherwise you're violating the license.
> >
> > AFAICT it's not a copy, it's a reimplementation - and he credited you in the
> > CREDITS file, for providing a reference implementation. But we can credit you
> > to the header as well - Pekka?
>
> It's actually not my code, but Fabrice's. I compared
> get_cluster_offset() and it looks similar enough to me to qualify as a
> modified copy.
Well, i asked Prasad whether he copied any code and he said no (so it's not a
copy AFAICT) - but i nevertheless asked him to add proper attribution in any
case because he used it as a reference.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-14 8:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 19:26 [PATCH v2] kvm tool: add QCOW verions 1 read/write support Prasad Joshi
2011-04-13 19:48 ` Pekka Enberg
2011-04-14 6:18 ` [PATCH] kvm tool: Remove unused variables from the QCOW code Ingo Molnar
2011-04-14 8:02 ` [PATCH v2] kvm tool: add QCOW verions 1 read/write support Kevin Wolf
2011-04-14 8:07 ` Ingo Molnar
2011-04-14 8:12 ` Kevin Wolf
2011-04-14 8:15 ` Pekka Enberg
2011-04-14 8:26 ` Kevin Wolf
2011-04-14 8:27 ` Ingo Molnar
2011-04-14 9:23 ` Prasad Joshi
2011-04-14 9:28 ` Ingo Molnar
2011-04-14 9:53 ` Pekka Enberg
2011-04-14 8:25 ` Ingo Molnar [this message]
2011-04-14 8:21 ` Pekka Enberg
2011-04-14 8:31 ` Kevin Wolf
2011-04-14 8:32 ` Pekka Enberg
2011-04-14 8:49 ` Alon Levy
2011-04-14 8:52 ` Kevin Wolf
2011-04-14 9:26 ` Markus Armbruster
2011-04-14 9:52 ` Kevin Wolf
2011-04-14 10:02 ` Markus Armbruster
2011-04-14 9:53 ` Stefan Hajnoczi
2011-04-14 14:59 ` Anthony Liguori
2011-04-15 6:41 ` Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support) Markus Armbruster
2011-04-15 6:45 ` Pekka Enberg
2011-04-15 10:14 ` Stefan Hajnoczi
2011-04-15 11:17 ` Pekka Enberg
2011-04-15 12:05 ` Stefan Hajnoczi
2011-04-15 12:10 ` Pekka Enberg
2011-04-15 12:17 ` Why QCOW1? Kevin Wolf
2011-04-15 12:12 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414082540.GA30848@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox