From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support Date: Thu, 14 Apr 2011 10:25:40 +0200 Message-ID: <20110414082540.GA30848@elte.hu> References: <1302722762-30517-1-git-send-email-prasadjoshi124@gmail.com> <4DA6AA2F.2020306@redhat.com> <20110414080748.GB23965@elte.hu> <4DA6AC83.7000601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Prasad Joshi , kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com, stefanha@linux.vnet.ibm.com To: Kevin Wolf Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:41799 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089Ab1DNIZ6 (ORCPT ); Thu, 14 Apr 2011 04:25:58 -0400 Content-Disposition: inline In-Reply-To: <4DA6AC83.7000601@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Kevin Wolf wrote: > Am 14.04.2011 10:07, schrieb Ingo Molnar: > > > > * Kevin Wolf wrote: > > > >> Also at least your qcow1.c is lacking the copyright header. Please add this, > >> otherwise you're violating the license. > > > > AFAICT it's not a copy, it's a reimplementation - and he credited you in the > > CREDITS file, for providing a reference implementation. But we can credit you > > to the header as well - Pekka? > > It's actually not my code, but Fabrice's. I compared > get_cluster_offset() and it looks similar enough to me to qualify as a > modified copy. Well, i asked Prasad whether he copied any code and he said no (so it's not a copy AFAICT) - but i nevertheless asked him to add proper attribution in any case because he used it as a reference. Thanks, Ingo