public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Pekka Enberg <penberg@kernel.org>,
	kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	levinsasha928@gmail.com, stefanha@linux.vnet.ibm.com
Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support
Date: Thu, 14 Apr 2011 11:28:57 +0200	[thread overview]
Message-ID: <20110414092857.GA19503@elte.hu> (raw)
In-Reply-To: <BANLkTikvE53pfGOM=4HFD23fd=qF1KkMjg@mail.gmail.com>


* Prasad Joshi <prasadjoshi124@gmail.com> wrote:

> Speaking about the code of finding the cluster offset is so basic, that I 
> thought it should be implemented the way it is done in the QEMU. But none of 
> the code is copied from the QEMU sources. The complete code is written from 
> scratch with QEMU sources as a reference. [...]

I think we should put that info into a prominent place in the source file 
together with a very prominent acknowledgement to the Qemu implementation as 
well.

Thanks,

	Ingo

  reply	other threads:[~2011-04-14  9:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 19:26 [PATCH v2] kvm tool: add QCOW verions 1 read/write support Prasad Joshi
2011-04-13 19:48 ` Pekka Enberg
2011-04-14  6:18   ` [PATCH] kvm tool: Remove unused variables from the QCOW code Ingo Molnar
2011-04-14  8:02 ` [PATCH v2] kvm tool: add QCOW verions 1 read/write support Kevin Wolf
2011-04-14  8:07   ` Ingo Molnar
2011-04-14  8:12     ` Kevin Wolf
2011-04-14  8:15       ` Pekka Enberg
2011-04-14  8:26         ` Kevin Wolf
2011-04-14  8:27           ` Ingo Molnar
2011-04-14  9:23             ` Prasad Joshi
2011-04-14  9:28               ` Ingo Molnar [this message]
2011-04-14  9:53               ` Pekka Enberg
2011-04-14  8:25       ` Ingo Molnar
2011-04-14  8:21   ` Pekka Enberg
2011-04-14  8:31     ` Kevin Wolf
2011-04-14  8:32       ` Pekka Enberg
2011-04-14  8:49         ` Alon Levy
2011-04-14  8:52         ` Kevin Wolf
2011-04-14  9:26           ` Markus Armbruster
2011-04-14  9:52             ` Kevin Wolf
2011-04-14 10:02               ` Markus Armbruster
2011-04-14  9:53             ` Stefan Hajnoczi
2011-04-14 14:59           ` Anthony Liguori
2011-04-15  6:41   ` Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support) Markus Armbruster
2011-04-15  6:45     ` Pekka Enberg
2011-04-15 10:14       ` Stefan Hajnoczi
2011-04-15 11:17         ` Pekka Enberg
2011-04-15 12:05           ` Stefan Hajnoczi
2011-04-15 12:10             ` Pekka Enberg
2011-04-15 12:17             ` Why QCOW1? Kevin Wolf
2011-04-15 12:12           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110414092857.GA19503@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox