From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support
Date: Thu, 14 Apr 2011 11:28:57 +0200
Message-ID: <20110414092857.GA19503@elte.hu>
References: <1302722762-30517-1-git-send-email-prasadjoshi124@gmail.com>
 <4DA6AA2F.2020306@redhat.com>
 <20110414080748.GB23965@elte.hu>
 <4DA6AC83.7000601@redhat.com>
 <BANLkTimfzZOsDcpd7VJi8agcd28NGJ6LfA@mail.gmail.com>
 <4DA6AFA7.80903@redhat.com>
 <20110414082743.GB30848@elte.hu>
 <BANLkTikvE53pfGOM=4HFD23fd=qF1KkMjg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Kevin Wolf <kwolf@redhat.com>, Pekka Enberg <penberg@kernel.org>,
	kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	levinsasha928@gmail.com, stefanha@linux.vnet.ibm.com
To: Prasad Joshi <prasadjoshi124@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:55483 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754096Ab1DNJ3Q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 14 Apr 2011 05:29:16 -0400
Content-Disposition: inline
In-Reply-To: <BANLkTikvE53pfGOM=4HFD23fd=qF1KkMjg@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Prasad Joshi <prasadjoshi124@gmail.com> wrote:

> Speaking about the code of finding the cluster offset is so basic, that I 
> thought it should be implemented the way it is done in the QEMU. But none of 
> the code is copied from the QEMU sources. The complete code is written from 
> scratch with QEMU sources as a reference. [...]

I think we should put that info into a prominent place in the source file 
together with a very prominent acknowledgement to the Qemu implementation as 
well.

Thanks,

	Ingo