From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] kvm tool: Remove the __stringify* defination from the util.h Date: Sat, 16 Apr 2011 11:45:35 +0200 Message-ID: <20110416094535.GB24711@elte.hu> References: <1302896625-11041-1-git-send-email-prasadjoshi124@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Prasad Joshi , kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com, chaitanyakulkarni15@gmail.com To: Pekka Enberg Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:38935 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758863Ab1DPJpi (ORCPT ); Sat, 16 Apr 2011 05:45:38 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: * Pekka Enberg wrote: > On Fri, Apr 15, 2011 at 10:43 PM, Prasad Joshi wrote: > > Include the Linux kernel header file linux/stringify.h file instead= of > > redefining the __stringify* macros > > > > Signed-off-by: Prasad Joshi > > --- > > =A0tools/kvm/include/kvm/util.h | =A0 =A05 ++--- > > =A01 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/u= til.h > > index ae033cc..c308f3f 100644 > > --- a/tools/kvm/include/kvm/util.h > > +++ b/tools/kvm/include/kvm/util.h > > @@ -1,3 +1,5 @@ > > +#include "../../../../include/linux/stringify.h" >=20 > #include should just work, no? Only if kernel headers are installed. Also, and perhaps more importantl= y, in=20 the context of perf it was more robust to use the same kernel repo's so= urce=20 code that perf resides in - should there be any fixes needed it's a lot= easier=20 to remedy things. Thanks, Ingo