From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tool: Remove the __stringify* defination from the
 util.h
Date: Sat, 16 Apr 2011 11:49:10 +0200
Message-ID: <20110416094910.GC24711@elte.hu>
References: <1302896625-11041-1-git-send-email-prasadjoshi124@gmail.com>
 <BANLkTime5Zwqj0pLy6_Kxo1BTaLiOEto8A@mail.gmail.com>
 <20110416094535.GB24711@elte.hu>
 <alpine.DEB.2.00.1104161247000.5863@tiger>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com,
	chaitanyakulkarni15@gmail.com
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:38915 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758590Ab1DPJtO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 16 Apr 2011 05:49:14 -0400
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1104161247000.5863@tiger>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Sat, 16 Apr 2011, Ingo Molnar wrote:
>=20
> >
> >* Pekka Enberg <penberg@kernel.org> wrote:
> >
> >>On Fri, Apr 15, 2011 at 10:43 PM, Prasad Joshi <prasadjoshi124@gmai=
l.com> wrote:
> >>>Include the Linux kernel header file linux/stringify.h file instea=
d of
> >>>redefining the __stringify* macros
> >>>
> >>>Signed-off-by: Prasad Joshi <prasadjoshi124@gmail.com>
> >>>---
> >>>=A0tools/kvm/include/kvm/util.h | =A0 =A05 ++---
> >>>=A01 files changed, 2 insertions(+), 3 deletions(-)
> >>>
> >>>diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/=
util.h
> >>>index ae033cc..c308f3f 100644
> >>>--- a/tools/kvm/include/kvm/util.h
> >>>+++ b/tools/kvm/include/kvm/util.h
> >>>@@ -1,3 +1,5 @@
> >>>+#include "../../../../include/linux/stringify.h"
> >>
> >>#include <linux/stringify.h> should just work, no?
> >
> >Only if kernel headers are installed. Also, and perhaps more importa=
ntly, in
> >the context of perf it was more robust to use the same kernel repo's=
 source
> >code that perf resides in - should there be any fixes needed it's a =
lot easier
> >to remedy things.
>=20
> We do this in the Makefile:
>=20
> -I../../include -I../../arch/$(ARCH)/include/
>=20
> so it should just work.

Oh, nice! :-)

Thanks,

	Ingo