From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tools: Add robust error handling for fork/waitpid()
Date: Mon, 18 Apr 2011 08:34:40 +0200
Message-ID: <20110418063440.GA12814@elte.hu>
References: <20110416095543.GA7305@elte.hu>
 <20110418001250.4934.17958.stgit@localhost6.localdomain6>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com
To: Amos Kong <kongjianjun@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:42440 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752573Ab1DRGep (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 Apr 2011 02:34:45 -0400
Content-Disposition: inline
In-Reply-To: <20110418001250.4934.17958.stgit@localhost6.localdomain6>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Amos Kong <kongjianjun@gmail.com> wrote:

> +		} else if (pid > 0) {
> +			while(waitpid(pid, &status, 0) != pid) {
>  			}
>  		}

Doesn't that look like an infinite loop when waitpid() returns an error?

Thanks,

	Ingo