public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: Asias He <asias.hejun@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	gorcunov@gmail.com, prasadjoshi124@gmail.com,
	kvm@vger.kernel.org
Subject: Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread
Date: Wed, 20 Apr 2011 10:54:42 +0200	[thread overview]
Message-ID: <20110420085442.GC1124@elte.hu> (raw)
In-Reply-To: <BANLkTinSA=k2kP271p-7xoN9jA5wc_Gtzg@mail.gmail.com>


* Pekka Enberg <penberg@kernel.org> wrote:

> Sorry for the bikeshedding but wouldn't it be better to follow Git's lead and 
> have something like
> 
>   kvm config MyInstance-1 --set debug.io.delay.ms 100
> 
> and
> 
>   kvm config MyInstance-1 --list

Yeah, agreed - 'kvm config' is intuitive. I tried to think of something better 
than 'kvm set' but failed.

 ( And no, being super diligent with high level, very user visible changes and
   names is not bikeshed painting. )

Note that 'git config' touches the .gitconfig IIRC - while here we really also 
want to include runtime, dynamic configuration - but i think that distinction 
is fine.

Now the whole 'kvm config' thing needs more thought and the whole enumeration 
of KVM instances needs to be well thought out as well. How do we list instances 
- 'kvm list' - or should perhaps 'kvm config' list all the currently running 
instances?

Thanks,

	Ingo

  reply	other threads:[~2011-04-20  8:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 13:02 [PATCH 1/4] kvm tools: Thread virtio-blk Sasha Levin
2011-04-18 13:02 ` [PATCH 2/4] kvm tools: Use virtio_blk_parameters to configure virtio-blk Sasha Levin
2011-04-18 13:02 ` [PATCH 3/4] kvm tools: Add debug feature to test the IO thread Sasha Levin
2011-04-19 16:52   ` Pekka Enberg
2011-04-19 17:04     ` Sasha Levin
2011-04-19 17:11       ` Ingo Molnar
2011-04-19 23:10         ` Asias He
2011-04-20  5:41           ` Pekka Enberg
2011-04-20  8:54             ` Ingo Molnar [this message]
2011-04-18 13:02 ` [PATCH 4/4] kvm tools: Complete missing segments in a iov op using regular op Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110420085442.GC1124@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox