From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread Date: Wed, 20 Apr 2011 10:54:42 +0200 Message-ID: <20110420085442.GC1124@elte.hu> References: <1303131754-25072-1-git-send-email-levinsasha928@gmail.com> <1303131754-25072-3-git-send-email-levinsasha928@gmail.com> <1303232667.6697.5.camel@stimpy> <20110419171116.GD6640@elte.hu> <4DAE165A.3070404@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Asias He , Sasha Levin , gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:44995 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095Ab1DTIyq (ORCPT ); Wed, 20 Apr 2011 04:54:46 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: * Pekka Enberg wrote: > Sorry for the bikeshedding but wouldn't it be better to follow Git's lead and > have something like > > kvm config MyInstance-1 --set debug.io.delay.ms 100 > > and > > kvm config MyInstance-1 --list Yeah, agreed - 'kvm config' is intuitive. I tried to think of something better than 'kvm set' but failed. ( And no, being super diligent with high level, very user visible changes and names is not bikeshed painting. ) Note that 'git config' touches the .gitconfig IIRC - while here we really also want to include runtime, dynamic configuration - but i think that distinction is fine. Now the whole 'kvm config' thing needs more thought and the whole enumeration of KVM instances needs to be well thought out as well. How do we list instances - 'kvm list' - or should perhaps 'kvm config' list all the currently running instances? Thanks, Ingo