From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 9/9] qemu-kvm: hpet: Add MSI support for in-kernel
 irqchip mode
Date: Tue, 26 Apr 2011 12:06:02 -0400
Message-ID: <20110426160602.GA1048@infradead.org>
References: <cover.1303823975.git.jan.kiszka@siemens.com>
 <3d089633897515a214af032ed633342a7001945f.1303823975.git.jan.kiszka@siemens.com>
 <4DB6D01C.6080706@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:41074 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753908Ab1DZQGF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 26 Apr 2011 12:06:05 -0400
Content-Disposition: inline
In-Reply-To: <4DB6D01C.6080706@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Apr 26, 2011 at 04:01:00PM +0200, Jan Kiszka wrote:
> +static bool modifying_bit(uint64_t old, uint64_t new, uint64_t mask)
> +{
> +    return (old ^ new) & mask;
> +}
> +

A more usual name would be toggle_bit.  But you're passing in a mask
to be modified, so it would be more a toggle_bits or toggle_mask.