From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 2/7] qemu-kvm: Rename kvm_msix_message to KVMMsiMessage Date: Wed, 27 Apr 2011 17:36:09 +0300 Message-ID: <20110427143609.GS15788@redhat.com> References: <34c1e72dbc96d7a3f03f064093d101e2f4cb03b2.1303554218.git.jan.kiszka@web.de> <20110427133400.GH15788@redhat.com> <4DB8227C.9030907@siemens.com> <4DB82836.9000708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1029 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757377Ab1D0OgW (ORCPT ); Wed, 27 Apr 2011 10:36:22 -0400 Content-Disposition: inline In-Reply-To: <4DB82836.9000708@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 27, 2011 at 05:29:10PM +0300, Avi Kivity wrote: > On 04/27/2011 05:04 PM, Jan Kiszka wrote: > >> > >> I put kvm_msix_message in pci.h to avoid having every pci device pull in kvm.h > >> is anything wrong with that? Maybe just rename it to make it generic > >> for msi and leave if where it is. > > > >kvm.h shall provide kvm related types, not some unrelated header. That's > >even more important with MSI support for non-PCI devices (aka HPET). > > We could have an MSIMessage type that abstracts the general > facility, and let it embed a KVMMsiMessage that contains just the > gsi. The whole structure is only needed for kvm though: no one else seems to want an MSIMessage. > -- > error compiling committee.c: too many arguments to function