From: Ingo Molnar <mingo@elte.hu>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Sasha Levin <levinsasha928@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] kvm tools: Make virtio-console kvm__irq_line thread safe
Date: Fri, 29 Apr 2011 08:44:57 +0200 [thread overview]
Message-ID: <20110429064457.GC13893@elte.hu> (raw)
In-Reply-To: <1304058985-13833-2-git-send-email-asias.hejun@gmail.com>
* Asias He <asias.hejun@gmail.com> wrote:
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
> tools/kvm/virtio-console.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/tools/kvm/virtio-console.c b/tools/kvm/virtio-console.c
> index e66d198..492c859 100644
> --- a/tools/kvm/virtio-console.c
> +++ b/tools/kvm/virtio-console.c
> @@ -162,7 +162,9 @@ static void virtio_console_handle_callback(struct kvm *self, void *param)
> virt_queue__set_used_elem(vq, head, len);
> }
>
> + mutex_lock(&console_device.mutex);
> kvm__irq_line(self, VIRTIO_CONSOLE_IRQ, 1);
> + mutex_unlock(&console_device.mutex);
> }
This looks wrong for similar reasons as for virtio-blk.c.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-29 6:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 6:36 [PATCH 1/3] kvm tools: Make virtio-net kvm__irq_line thread safe Asias He
2011-04-29 6:36 ` [PATCH 2/3] kvm tools: Make virtio-console " Asias He
2011-04-29 6:44 ` Ingo Molnar [this message]
2011-04-29 6:36 ` [PATCH 3/3] kvm tools: Make virtio-blk " Asias He
2011-04-29 6:44 ` Ingo Molnar
2011-04-29 6:55 ` Pekka Enberg
2011-04-29 7:26 ` Asias He
2011-04-29 7:55 ` Pekka Enberg
2011-04-29 8:29 ` Sasha Levin
2011-04-29 6:46 ` [PATCH 1/3] kvm tools: Make virtio-net " Ingo Molnar
2011-04-29 6:52 ` Pekka Enberg
2011-04-29 7:13 ` Asias He
2011-04-29 7:15 ` Pekka Enberg
2011-04-29 7:38 ` Asias He
2011-04-29 7:45 ` Ingo Molnar
2011-04-29 7:53 ` Sasha Levin
2011-04-29 10:02 ` Cyrill Gorcunov
2011-04-29 10:37 ` Pekka Enberg
2011-04-29 10:47 ` Cyrill Gorcunov
2011-04-29 10:22 ` Ingo Molnar
2011-04-29 16:52 ` Sasha Levin
2011-04-29 20:39 ` Ingo Molnar
2011-04-29 7:30 ` Ingo Molnar
2011-04-29 7:47 ` Asias He
2011-04-29 10:32 ` Ingo Molnar
2011-04-29 10:42 ` Pekka Enberg
2011-04-29 17:43 ` Pekka Enberg
2011-04-29 19:59 ` Ingo Molnar
2011-04-30 7:44 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429064457.GC13893@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).