From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [PATCH 2/2 V7] qemu,
	qmp: add inject-nmi qmp command
Date: Tue, 3 May 2011 10:54:36 +0100
Message-ID: <20110503095436.GI5832@shareable.org>
References: <20110406150818.56707b9b@doriath> <4D9CAE4B.7080305@siemens.com>
	<20110406160020.373cb5a2@doriath>
	<BANLkTinUfnq6b2u_bfdB_zc3z8dg=4gAbA@mail.gmail.com>
	<4D9CC044.2000705@codemonkey.ws>
	<BANLkTim4iP_YRjOCYH986BB=ec-dwcjfQA@mail.gmail.com>
	<4D9E0352.2050204@codemonkey.ws> <20110407185108.GE7100@redhat.com>
	<4D9E2F2E.8070203@codemonkey.ws>
	<20110408055401.GA25354@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Peter Maydell <peter.maydell@linaro.org>, Lai Jiangshan <eag0628@gmail.com>,
	Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org,
	Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org,
	Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <20110408055401.GA25354@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

Gleb Natapov wrote:
> On Thu, Apr 07, 2011 at 04:39:58PM -0500, Anthony Liguori wrote:
> > On 04/07/2011 01:51 PM, Gleb Natapov wrote:
> > >NMI does not have to generate crash dump on every guest we support.
> > >Actually even for windows guest it does not generate one without
> > >tweaking registry. For all I know there is a guest that checks mail when
> > >NMI arrives.
> > 
> > And for all we know, a guest can respond to an ACPI poweroff event
> > by tweeting the star spangled banner but we still call the
> > corresponding QMP command system_poweroff.
> > 
> Correct :) But at least system_poweroff implements ACPI poweroff as
> defined by ACPI spec. NMI is not designed as core dump event and is not
> used as such by majority of the guests.

Imho acpi_poweroff or poweroff_button would have been a clearer name.
Or even 'sendkey poweroff' - it's just a button someone on the
keyboard on a lot of systems anyway.  Next to the email button and what
looks, on my laptop, like the play-a-tune button :-)

I put system_poweroff into some QEMU-controlling scripts once, and was
disappointed when several guests ignored it.

But it's done now.

-- Jamie