From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Edgar E. Iglesias" Subject: Re: [PATCH v2] Import Linux headers for KVM and vhost Date: Tue, 3 May 2011 19:32:00 +0200 Message-ID: <20110503173200.GA30864@laped.lan> References: <4DC00BB1.7000008@siemens.com> <4DC031CC.1040902@siemens.com> <4DC0336B.7020106@redhat.com> <4DC036AD.7070306@siemens.com> <4DC037A0.2090507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , kvm , Jan Kiszka , Marcelo Tosatti , qemu-devel , Alexander Graf To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4DC037A0.2090507@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Tue, May 03, 2011 at 08:13:04PM +0300, Avi Kivity wrote: > On 05/03/2011 08:09 PM, Jan Kiszka wrote: > > > > > > Reluctant ack. > > > > What downsides do you see? > > The usual "it shouldn't be this way". Every other package (including, I > think, glibc) uses the sanitized system headers. Except for kvm-kmod, > the system headers are always available. I agree, it doesn't feel quite right to bring in the headers. I don't have any alternative suggestions (besides better HOWTOs/Documentation) though. Cheers