public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Tue, 3 May 2011 22:47:16 +0200	[thread overview]
Message-ID: <20110503204716.GA27887@elte.hu> (raw)
In-Reply-To: <1304454487-2539-2-git-send-email-levinsasha928@gmail.com>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> Increase idx only after updating the used element.
> Not doing so may mark a buffer as used without having
> it's head and length updated.
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  tools/kvm/virtio.c |   19 ++++++++++++++++++-
>  1 files changed, 18 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/kvm/virtio.c b/tools/kvm/virtio.c
> index 6249521..266a1b6 100644
> --- a/tools/kvm/virtio.c
> +++ b/tools/kvm/virtio.c
> @@ -1,15 +1,32 @@
>  #include <linux/virtio_ring.h>
>  #include <stdint.h>
>  #include <sys/uio.h>
> +#include <asm/system.h>

If this system.h is included from the current kernel (and not from the 
system's) then:

Acked-by: Ingo Molnar <mingo@elte.hu>

Thanks,

	Ingo

  reply	other threads:[~2011-05-03 20:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 20:28 [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Sasha Levin
2011-05-03 20:28 ` [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem Sasha Levin
2011-05-03 20:47   ` Ingo Molnar [this message]
2011-05-04  4:41     ` Sasha Levin
2011-05-04  6:33       ` Ingo Molnar
2011-05-04 23:47       ` Asias He
2011-05-05  4:38         ` Sasha Levin
2011-05-05  7:02         ` Ingo Molnar
2011-05-05  7:13           ` Pekka Enberg
2011-05-05  7:18             ` Sasha Levin
2011-05-05  7:32               ` Pekka Enberg
2011-05-05  7:47             ` Ingo Molnar
2011-05-05  7:52               ` Pekka Enberg
2011-05-05  8:01                 ` Sasha Levin
2011-05-05  8:07                 ` Ingo Molnar
2011-05-05  8:12                   ` Ingo Molnar
2011-05-05  8:22                     ` [PATCH] kvm: Fix 32-bit build of the asm/system.h include Ingo Molnar
2011-05-05 14:45                       ` Pekka Enberg
2011-05-05 15:33                         ` Asias He
2011-05-03 20:35 ` [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110503204716.GA27887@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox