From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem Date: Wed, 4 May 2011 08:33:49 +0200 Message-ID: <20110504063349.GA20828@elte.hu> References: <1304454487-2539-1-git-send-email-levinsasha928@gmail.com> <1304454487-2539-2-git-send-email-levinsasha928@gmail.com> <20110503204716.GA27887@elte.hu> <1304484063.13143.9.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:34367 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075Ab1EDGeA (ORCPT ); Wed, 4 May 2011 02:34:00 -0400 Content-Disposition: inline In-Reply-To: <1304484063.13143.9.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > On Tue, 2011-05-03 at 22:47 +0200, Ingo Molnar wrote: > > * Sasha Levin wrote: > > > > > Increase idx only after updating the used element. > > > Not doing so may mark a buffer as used without having > > > it's head and length updated. > > > > > > Signed-off-by: Sasha Levin > > > --- > > > tools/kvm/virtio.c | 19 ++++++++++++++++++- > > > 1 files changed, 18 insertions(+), 1 deletions(-) > > > > > > diff --git a/tools/kvm/virtio.c b/tools/kvm/virtio.c > > > index 6249521..266a1b6 100644 > > > --- a/tools/kvm/virtio.c > > > +++ b/tools/kvm/virtio.c > > > @@ -1,15 +1,32 @@ > > > #include > > > #include > > > #include > > > +#include > > > > If this system.h is included from the current kernel (and not from the > > system's) then: > > > > Acked-by: Ingo Molnar > > > > The system.h that'll get picked up is > '../../arch/$(ARCH)/include/asm/system.h' within the current kernel tree > and not the system one. ok, that's great - so my Ack stands. Thanks, Ingo