From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 1/1 v2] KVM: MMU: Use ptep_user for cmpxchg_gpte() Date: Wed, 4 May 2011 13:13:00 -0300 Message-ID: <20110504161300.GA5274@amt.cnet> References: <20110501143026.9eb3c875.takuya.yoshikawa@gmail.com> <20110501143307.1bcfd375.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42369 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760Ab1EDQN3 (ORCPT ); Wed, 4 May 2011 12:13:29 -0400 Content-Disposition: inline In-Reply-To: <20110501143307.1bcfd375.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, May 01, 2011 at 02:33:07PM +0900, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > The address of the gpte was already calculated and stored in ptep_user > before entering cmpxchg_gpte(). > > This patch makes cmpxchg_gpte() to use that to make it clear that we > are using the same address during walk_addr_generic(). > > Note that the unlikely annotations are used to show that the conditions > are something unusual rather than for performance. > > Signed-off-by: Takuya Yoshikawa > --- > arch/x86/kvm/paging_tmpl.h | 26 ++++++++++++-------------- > 1 files changed, 12 insertions(+), 14 deletions(-) Applied, thanks.