From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Thu, 5 May 2011 10:12:53 +0200
Message-ID: <20110505081253.GA20499@elte.hu>
References: <1304454487-2539-1-git-send-email-levinsasha928@gmail.com>
 <1304454487-2539-2-git-send-email-levinsasha928@gmail.com>
 <20110503204716.GA27887@elte.hu>
 <1304484063.13143.9.camel@lappy>
 <4DC1E57B.3060809@gmail.com>
 <20110505070211.GA13043@elte.hu>
 <BANLkTikU76tDjdEBdXFTJvm-aH45oFGqkw@mail.gmail.com>
 <20110505074716.GC14391@elte.hu>
 <BANLkTi=Lg7K-hXBKRCFv48MkiKY_bwL2QA@mail.gmail.com>
 <20110505080729.GD14391@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Asias He <asias.hejun@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>, gorcunov@gmail.com,
	prasadjoshi124@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:55531 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751338Ab1EEIM6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 May 2011 04:12:58 -0400
Content-Disposition: inline
In-Reply-To: <20110505080729.GD14391@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Ingo Molnar <mingo@elte.hu> wrote:

> I'm not entirely happy about how it has added dependent includes to virtio.c 
> but that's a property of this messy header file. Might be worth adding a 
> comment about that.

This block:

> +#include <linux/stringify.h>
> +#include <linux/bitops.h>
> +#include <asm/alternative.h>
>  #include <asm/system.h>

Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment - 
that way the virtio.c inclusion looks very clean.

Note: i'd not put it into linux/barrier.h, to not clash with any possible 
future linux/barrier.h file, and to also make it clear that this is a kvm 
specific wrapper.

Oh, and those 3 lines could be put into upstream arch/x86's system.h as well, 
to make asm/system.h standalone includable. Does anyone want to send a patch 
for that?

Once that header fix is upstream and once tools/kvm/ merges that upstream 
kernel the special wrapper barrier.h can be dropped and virtio.c can include 
asm/system.h for the barriers.

The joys of a clean Git workflow and a unified kernel+tools tree, it actually 
helps fix crap on both sides :-)

Thanks,

	Ingo