From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 04/19] qemu-kvm: x86: Drop MSR reset Date: Thu, 5 May 2011 10:33:01 -0300 Message-ID: <20110505133301.GA20018@amt.cnet> References: <4DC25AF3.6050704@redhat.com> <4DC25BC5.9090801@siemens.com> <4DC25CDB.9060805@redhat.com> <4DC25F82.2040501@siemens.com> <4DC260DD.5010807@redhat.com> <4DC26388.4090207@siemens.com> <4DC265A5.90301@redhat.com> <4DC26EAA.7080803@siemens.com> <20110505112257.GE19019@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Avi Kivity , "kvm@vger.kernel.org" To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22921 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284Ab1EENdd (ORCPT ); Thu, 5 May 2011 09:33:33 -0400 Content-Disposition: inline In-Reply-To: <20110505112257.GE19019@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 05, 2011 at 02:22:57PM +0300, Gleb Natapov wrote: > On Thu, May 05, 2011 at 11:32:26AM +0200, Jan Kiszka wrote: > > >> > > > >> > Of course, if we get a patch soon no one will ever see the > > >> regression so > > >> > we can apply the series. > > >> > > >> I will still require the usual testing and merging round via upstream > > >> and back. Not sure when I'll be able to work on it, probably not the > > >> next days. > > > > > > If you can do it within a couple of weeks or so that should be fine. > > > > > > > We'll see, but I still do not share your concern regarding future > > regressions when removing the fragile reset code. > > > Why do we rely on userspace to properly reset kernel component anyway? In general its required that userspace properly sets (some of) the parameters of emulated hardware, including on reset. > We should introduce cpu/lapic/ioapic/pit/pic resets ASAP. Thats done through userspace via ioctls, don't get your point?