From: Ingo Molnar <mingo@elte.hu>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
prasadjoshi124@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH 5/5] kvm tools: virtio-rng code cleanup
Date: Thu, 5 May 2011 21:06:08 +0200 [thread overview]
Message-ID: <20110505190608.GA23311@elte.hu> (raw)
In-Reply-To: <1304620475-10289-5-git-send-email-levinsasha928@gmail.com>
* Sasha Levin <levinsasha928@gmail.com> wrote:
> +struct rng_dev {
> + u8 status;
> + u16 config_vector;
> int fd_rng;
I think you forgot the fd_rng -> fd rename?
The cleanup series looks very nice otherwise:
Acked-by: Ingo Molnar <mingo@elte.hu>
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-05 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 18:34 [PATCH 1/5] kvm tools: Abolishment of uint*_t types Sasha Levin
2011-05-05 18:34 ` [PATCH 2/5] kvm tools: virtio-blk code cleanup Sasha Levin
2011-05-05 18:34 ` [PATCH 3/5] kvm tools: virtio-console " Sasha Levin
2011-05-05 18:34 ` [PATCH 4/5] kvm tools: virtio-net " Sasha Levin
2011-05-05 18:34 ` [PATCH 5/5] kvm tools: virtio-rng " Sasha Levin
2011-05-05 19:06 ` Ingo Molnar [this message]
2011-05-05 19:02 ` [PATCH 1/5] kvm tools: Abolishment of uint*_t types Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505190608.GA23311@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox