From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 5/5] kvm tools: virtio-rng code cleanup Date: Thu, 5 May 2011 21:06:08 +0200 Message-ID: <20110505190608.GA23311@elte.hu> References: <1304620475-10289-1-git-send-email-levinsasha928@gmail.com> <1304620475-10289-5-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:46109 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718Ab1EETGO (ORCPT ); Thu, 5 May 2011 15:06:14 -0400 Content-Disposition: inline In-Reply-To: <1304620475-10289-5-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > +struct rng_dev { > + u8 status; > + u16 config_vector; > int fd_rng; I think you forgot the fd_rng -> fd rename? The cleanup series looks very nice otherwise: Acked-by: Ingo Molnar Thanks, Ingo