From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/3] kvm tools: Introduce virtio-rng
Date: Fri, 6 May 2011 00:00:01 +0200
Message-ID: <20110505220001.GA1674@elte.hu>
References: <1304170225-4859-1-git-send-email-levinsasha928@gmail.com>
 <1304170225-4859-2-git-send-email-levinsasha928@gmail.com>
 <20110505065423.GD28015@elte.hu>
 <BANLkTikW1UFQtGSuCTKH00MBOf5e-39EqA@mail.gmail.com>
 <20110505071241.GB13768@elte.hu>
 <BANLkTikJHU2Tvhn+y+ib-mheFM-JVxRJkQ@mail.gmail.com>
 <1304611455.3922.1.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>, asias.hejun@gmail.com,
	gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:50346 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750853Ab1EEWAP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 May 2011 18:00:15 -0400
Content-Disposition: inline
In-Reply-To: <1304611455.3922.1.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> On Thu, 2011-05-05 at 10:14 +0300, Pekka Enberg wrote:
> > On Thu, May 5, 2011 at 10:12 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > > another thing i noticed: the patch introduces some new uint_* usages.
> > >
> > > Once things are fixed can we somehow kill that datatype intelligently, so that
> > > if new code uses it the build breaks or so?
> > 
> > I guess we could do
> > 
> >   include/stdint.h
> > 
> > that does
> > 
> >   #error You lose.
> > 
> > or something.
> 
> How would we handle <linux/inet.h> which uses uint*_t types?

Yeah, it's not realistic to get rid of them like that - also, system include 
files are using it as well.

Thanks,

	Ingo