public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Campos <rodrigo@sdfg.com.ar>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	KVM devel mailing list <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tools: Enable earlyprintk=serial by default
Date: Sun, 8 May 2011 10:25:53 -0300	[thread overview]
Message-ID: <20110508132553.GA31556@debian> (raw)
In-Reply-To: <20110508073934.GA28049@elte.hu>

On Sun, May 08, 2011 at 09:39:34AM +0200, Ingo Molnar wrote:
> 
> diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c
> index 764a242..eb50b6a 100644
> --- a/tools/kvm/kvm-run.c
> +++ b/tools/kvm/kvm-run.c
> @@ -409,7 +409,7 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix)
>  	kvm->nrcpus = nrcpus;
>  
>  	memset(real_cmdline, 0, sizeof(real_cmdline));
> -	strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 ");
> +	strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serial");

I think the space at the end of the string that you delete, squashes the early
printk option with the next one (root= in your case), like in the output you show:

>  [    0.000000] Command line: notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serialroot=/dev/vda1 rw 
I mean here                                                                                   ^





Thanks,
Rodrigo

      reply	other threads:[~2011-05-08 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08  7:39 [PATCH] kvm tools: Enable earlyprintk=serial by default Ingo Molnar
2011-05-08 13:25 ` Rodrigo Campos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110508132553.GA31556@debian \
    --to=rodrigo@sdfg.com.ar \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox