From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Campos Subject: Re: [PATCH] kvm tools: Enable earlyprintk=serial by default Date: Sun, 8 May 2011 10:25:53 -0300 Message-ID: <20110508132553.GA31556@debian> References: <20110508073934.GA28049@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , KVM devel mailing list To: Ingo Molnar Return-path: Received: from alerce.vps.bitfolk.com ([212.13.194.134]:57950 "EHLO alerce.vps.bitfolk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab1EHN7r (ORCPT ); Sun, 8 May 2011 09:59:47 -0400 Content-Disposition: inline In-Reply-To: <20110508073934.GA28049@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, May 08, 2011 at 09:39:34AM +0200, Ingo Molnar wrote: > > diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c > index 764a242..eb50b6a 100644 > --- a/tools/kvm/kvm-run.c > +++ b/tools/kvm/kvm-run.c > @@ -409,7 +409,7 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix) > kvm->nrcpus = nrcpus; > > memset(real_cmdline, 0, sizeof(real_cmdline)); > - strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 "); > + strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serial"); I think the space at the end of the string that you delete, squashes the early printk option with the next one (root= in your case), like in the output you show: > [ 0.000000] Command line: notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serialroot=/dev/vda1 rw I mean here ^ Thanks, Rodrigo