From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH v3 1/3] PCI: Track the size of each saved capability
 data area
Date: Mon, 9 May 2011 13:43:56 -0700
Message-ID: <20110509134356.63f66a29@jbarnes-desktop>
References: <20110420202523.3189.31306.stgit@s20.home>
	<20110420203133.3189.22786.stgit@s20.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-pci@vger.kernel.org, kvm@vger.kernel.org, avi@redhat.com,
	linux-kernel@vger.kernel.org, jan.kiszka@siemens.com
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20110420203133.3189.22786.stgit@s20.home>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, 20 Apr 2011 14:31:33 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:

> -struct pci_cap_saved_state {
> -	struct hlist_node next;
> +struct pci_cap_saved {
>  	char cap_nr;
> +	unsigned int size;
>  	u32 data[0];
>  };
>  
> +struct pci_cap_saved_state {
> +	struct hlist_node next;
> +	struct pci_cap_saved saved;
> +};
> +
>  struct pcie_link_state;
>  struct pci_vpd;
>  struct pci_sriov;
> @@ -366,7 +371,7 @@ static inline struct pci_cap_saved_state *pci_find_saved_cap(
>  	struct hlist_node *pos;
>  
>  	hlist_for_each_entry(tmp, pos, &pci_dev->saved_cap_space, next) {
> -		if (tmp->cap_nr == cap)
> +		if (tmp->saved.cap_nr == cap)
>  			return tmp;
>  	}
>  	return NULL;

Looks pretty good in general.  But I think the naming makes it harder
to read than it ought to be.

So we have a pci_cap_saved_state, which implies capability info, and
that's fine.

But pci_cap_saved doesn't communicate much; maybe pci_cap_data or
pci_cap_saved_data would be better?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center