kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org
Cc: alex.williamson@redhat.com, kvm@vger.kernel.org, avi@redhat.com,
	linux-kernel@vger.kernel.org, jan.kiszka@siemens.com
Subject: [PATCH v4 0/3] Store and load PCI device saved state across function resets
Date: Tue, 10 May 2011 10:01:58 -0600	[thread overview]
Message-ID: <20110510155642.3490.61935.stgit@s20.home> (raw)

v3 -> v4:
  Renamed struct pci_cap_saved -> struct pci_cap_saved_data and
  the element name within struct pci_cap_saved_state to cap.

Jesse, I hope this helps provide the clarification you were looking
for.  Thanks for the comments.

v2 -> v3:
  Saved structure has variable contents.

v1 -> v2:
  Make the pointer passed around less opaque for type safety.

Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because
the KVM module attempts to do a pci_save_state() before assigning
the device to a VM, expecting that the saved state will remain
valid until we release the device.  This is in conflict with our
need to reset devices using PCI sysfs during a VM reset to
quiesce the device.  Any calls to pci_reset_function() will
overwrite the device saved stated prior to reset, and reload and
invalidate the state after.  KVM then ends up trying to restore
the state, but it's already invalid, so the device ends up with
reset values.

This series adds a mechanism to pull the saved state off the
struct pci_dev and reload it later.  Thanks,

Alex

---

Alex Williamson (3):
      KVM: Use pci_store/load_saved_state() around VM device usage
      PCI: Add interfaces to store and load the device saved state
      PCI: Track the size of each saved capability data area


 drivers/pci/pci.c        |  110 ++++++++++++++++++++++++++++++++++++++++++++--
 include/linux/kvm_host.h |    1 
 include/linux/pci.h      |   15 +++++-
 virt/kvm/assigned-dev.c  |   18 ++++++--
 4 files changed, 132 insertions(+), 12 deletions(-)

             reply	other threads:[~2011-05-10 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 16:01 Alex Williamson [this message]
2011-05-10 16:02 ` [PATCH v4 1/3] PCI: Track the size of each saved capability data area Alex Williamson
2011-05-21 16:10   ` Jesse Barnes
2011-05-10 16:02 ` [PATCH v4 2/3] PCI: Add interfaces to store and load the device saved state Alex Williamson
2011-05-10 16:02 ` [PATCH v4 3/3] KVM: Use pci_store/load_saved_state() around VM device usage Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510155642.3490.61935.stgit@s20.home \
    --to=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).