From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: KVM devel mailing list <kvm@vger.kernel.org>,
Asias He <asias.hejun@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
Sasha Levin <levinsasha928@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] kvm tools: Fix type mismatches on GCC 4.4 on 32-bit systems
Date: Fri, 13 May 2011 10:37:18 +0200 [thread overview]
Message-ID: <20110513083718.GD13647@elte.hu> (raw)
In-Reply-To: <BANLkTimPruk_knjTPZTNio1o4vKPb8CXXA@mail.gmail.com>
* Pekka Enberg <penberg@kernel.org> wrote:
> On Fri, May 13, 2011 at 11:19 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > @@ -162,7 +162,7 @@ static void kvm_register_mem_slot(struct kvm *kvm, u32 slot, u64 guest_phys, u64
> > .slot = slot,
> > .guest_phys_addr = guest_phys,
> > .memory_size = size,
> > - .userspace_addr = (u64)userspace_addr,
> > + .userspace_addr = (u64)(long)userspace_addr,
> > };
>
> Isn't
>
> + .userspace_addr = (unsigned long)userspace_addr,
>
> the right thing to do here?
Yeah, you are right - and userspace_addr will always be 32-bit on 32-bit hosts
so this is unrelated to the guest-pfn conversion thing.
More than 1-2 GB of RAM can be supported in the future by mmap()-ing a chunk,
passing the address to KVM and then unmapping it. In theory it is possible to
implement more than 4GB RAM support on 32-bit hosts without having to do
highmem alike tricks in tools/kvm/, but i doubt there's much interest in that -
everything is so much easier on 64-bit systems ...
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-13 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 8:19 [PATCH] kvm tools: Fix type mismatches on GCC 4.4 on 32-bit systems Ingo Molnar
2011-05-13 8:27 ` Pekka Enberg
2011-05-13 8:37 ` Ingo Molnar [this message]
2011-05-13 9:11 ` Sasha Levin
2011-05-13 10:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513083718.GD13647@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox