From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] kvm tools: Add interval red-black tree helper
Date: Tue, 17 May 2011 10:05:31 +0200
Message-ID: <20110517080531.GC22093@elte.hu>
References: <1305615515-13913-1-git-send-email-levinsasha928@gmail.com>
 <20110517074115.GG22305@elte.hu>
 <1305618929.12150.23.camel@sasha>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, asias.hejun@gmail.com,
	prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org,
	john@jfloren.net
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:45059 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752525Ab1EQIFj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 17 May 2011 04:05:39 -0400
Content-Disposition: inline
In-Reply-To: <1305618929.12150.23.camel@sasha>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> On Tue, 2011-05-17 at 09:41 +0200, Ingo Molnar wrote:
> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> > > +#include <kvm/interval-rbtree.h>
> > > +#include <stdio.h>
> > > +#include <stdlib.h>
> > 
> > At first sight i dont think you really need the stdio.h and stlib.h includes - 
> > you added these while having debugging printfs in the code?
> 
> We can drop either of them, but not both. Added it for size_t
> definition.

Oh, ok - sure!

> > So the rb-node iterator is named 'new', while the rb-int-node iterator is 
> > called 'this'? That does not make sense.
> 
> I actually took that bit from an example in Documentation/rbtree.txt of how 
> to write an insertion function :)

The kernel is far from perfect :-)

> Maybe it's worth doing another rbtree.txt patch and cleaning up the samples 
> there?

Yeah :-)

Thanks,

	Ingo